This repository was archived by the owner on Aug 23, 2021. It is now read-only.
SpliceMachine Support#185
Open
Covariants wants to merge 2 commits into
Open
Conversation
apavlo
changed the title
apavlo
suggested changes
Dec 16, 2017
Member
apavlo
left a comment
apavlo
left a comment
There was a problem hiding this comment.
Please make the requested changes.
| @@ -0,0 +1,70 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Member
There was a problem hiding this comment.
Please expunge this file from your commit history and rebase.
| <artifactId>ojdbc14</artifactId> | ||
| <version>10.2.0.1.0</version> | ||
| </dependency> | ||
| <dependency> |
Member
| orlnPrepStmt.setTimestamp(idx++, order_line.ol_delivery_d); | ||
| } else { | ||
| orlnPrepStmt.setNull(idx++, 0); | ||
| orlnPrepStmt.setTimestamp(idx++, null); |
Member
There was a problem hiding this comment.
Fix your formatting. This also looks to be a SpliceMachine specific change. Why doesn't "0" work?
Author
There was a problem hiding this comment.
I kind of forget the complaining message. I just keep receiving the complaining message if I do not change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splicemachine team.